jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/350536 )
Change subject: pagegenerators_tests.py: Fix test_unconnected_with_repo
......................................................................
pagegenerators_tests.py: Fix test_unconnected_with_repo
- Use `datetime.utcnow()` instead of `datetime.now()`.
- Increase the time buffer to 30 minutes, this is to make sure the
item has not been connected recently.
- Use `UnconnectedPageGenerator` instead of `site.unconnected_pages`.
`site.unconnected_pages` is tested separately in
`site_tests.TestSiteGeneratorsUncached.test_unconnected`.
- Print the related `item` in the error message which will be
helpful in debugging.
Bug: T163975
Change-Id: I6c97c9c9f303de3033f68ced78dd933cd87a4b30
---
M tests/pagegenerators_tests.py
1 file changed, 7 insertions(+), 6 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 507cd0a..4d34212 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -1355,11 +1355,12 @@
if self.site.hostname() == 'test.wikipedia.org':
raise unittest.SkipTest('test.wikipedia is misconfigured; T85358')
cnt = 0
- start_time = datetime.datetime.now() - datetime.timedelta(minutes=5)
# Pages which have been connected recently may still be reported as
- # unconnected. So try on an version that is a few minutes older if the
+ # unconnected. So try on a version that is a few minutes older if the
# tested site appears as a sitelink.
- for page in self.site.unconnected_pages(total=5):
+ start_time = \
+ datetime.datetime.utcnow() - datetime.timedelta(minutes=30)
+ for page in pagegenerators.UnconnectedPageGenerator(self.site, 3):
try:
item = pywikibot.ItemPage.fromPage(page)
except pywikibot.NoPage:
@@ -1371,10 +1372,10 @@
sitelinks = json.loads(revisions[0].text)['sitelinks']
self.assertNotIn(
self.site.dbName(), sitelinks,
- 'Page "{0}" is connected to a Wikibase '
- 'repository'.format(page.title()))
+ 'Page "{0}" is connected to {1} on Wikibase '
+ 'repository'.format(page.title(), item))
cnt += 1
- self.assertLessEqual(cnt, 5)
+ self.assertLessEqual(cnt, 3)
def test_unconnected_without_repo(self):
"""Test that it raises a ValueError on sites without
repository."""
--
To view, visit
https://gerrit.wikimedia.org/r/350536
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c97c9c9f303de3033f68ced78dd933cd87a4b30
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>