jenkins-bot has submitted this change and it was merged.
Change subject: [FIX] Use bytes for ipaddress module detection ......................................................................
[FIX] Use bytes for ipaddress module detection
With 1e54a7d6, it is necessary to specify bytes when attempting to detect whether the ipaddress module is sane.
Change-Id: If0daab025a626cca6b4f5bc5d70cd54f2d12b4b3 --- M pywikibot/tools/ip.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: XZise: Looks good to me, approved jenkins-bot: Verified
diff --git a/pywikibot/tools/ip.py b/pywikibot/tools/ip.py index 08c03a1..808c0cc 100644 --- a/pywikibot/tools/ip.py +++ b/pywikibot/tools/ip.py @@ -35,7 +35,7 @@ # https://pypi.python.org/pypi/ipaddress # However while it rejects u'1111', it will consider '1111' valid try: - ip_address('1111') + ip_address(b'1111') warn('ipaddress backport is defective; patching.', ImportWarning) orig_ip_address = ip_address # force all input to be a unicode object so it validates correctly
pywikibot-commits@lists.wikimedia.org