jenkins-bot has submitted this change and it was merged.
Change subject: interwiki: do not automatically log in
......................................................................
interwiki: do not automatically log in
For interwiki.py, self.site is not necessarily the site we will write
to, and we might want to write to different sites. Interwiki.py uses
the configured usernames to determine which sites we want to write to,
rather than -family: and -code:.
Bug: T108802
Change-Id: Iaedd4ae371ed494c9e448cbe76eb321e7633128f
---
M scripts/interwiki.py
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
John Vandenberg: Looks good to me, approved
Malafaya: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/scripts/interwiki.py b/scripts/interwiki.py
index f6b4c5b..e77e471 100755
--- a/scripts/interwiki.py
+++ b/scripts/interwiki.py
@@ -2588,7 +2588,6 @@
hintlessPageGen = pagegenerators.CombinedPageGenerator(
[hintlessPageGen, gen2])
- site.login()
bot = InterwikiBot()
if not hintlessPageGen:
--
To view, visit
https://gerrit.wikimedia.org/r/230995
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaedd4ae371ed494c9e448cbe76eb321e7633128f
Gerrit-PatchSet: 5
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Malafaya <malafaya(a)clix.pt>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: jenkins-bot <>