jenkins-bot has submitted this change and it was merged.
Change subject: fix and reenable cosmetic_changes' standardizePageFooter() ......................................................................
fix and reenable cosmetic_changes' standardizePageFooter()
using category.aslink() instead of .title(asLink=True) in textlib.categoryFormat(), thus preserving the sortKey.
this implicitly reverts I88b01681f59aab91d5f70e788eae3349b87455a8
bug: 66921 Change-Id: Ib0701600a300b2435ac8f2c3b8a55c89faf2c2fe --- M pywikibot/textlib.py M scripts/cosmetic_changes.py 2 files changed, 2 insertions(+), 3 deletions(-)
Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified
Objections: Xqt: There's a problem with this change, please improve
diff --git a/pywikibot/textlib.py b/pywikibot/textlib.py index 64dbf3c..bbac6a3 100644 --- a/pywikibot/textlib.py +++ b/pywikibot/textlib.py @@ -846,8 +846,7 @@ else: catLinks = ['[[Category:%s]]' % category for category in categories] else: - catLinks = [category.title(asLink=True, allowInterwiki=False) - for category in categories] + catLinks = [category.aslink() for category in categories]
if insite.category_on_one_line(): sep = ' ' diff --git a/scripts/cosmetic_changes.py b/scripts/cosmetic_changes.py index f9f2479..8fc65cf 100755 --- a/scripts/cosmetic_changes.py +++ b/scripts/cosmetic_changes.py @@ -170,7 +170,7 @@ if self.site.sitename() == u'commons:commons' and self.namespace == 6: text = self.commonsfiledesc(text) text = self.fixSelfInterwiki(text) -## bug 66921 text = self.standardizePageFooter(text) + text = self.standardizePageFooter(text) text = self.fixSyntaxSave(text) text = self.cleanUpLinks(text) text = self.cleanUpSectionHeaders(text)
pywikibot-commits@lists.wikimedia.org