jenkins-bot has submitted this change and it was merged.
Change subject: Simplify ItemPage.get() ......................................................................
Simplify ItemPage.get()
Update the dict returned by WikibasePage.get() instead of creating a new one from scratch.
Change-Id: Ib85b205858761386ed61b7460de2081bc591b365 --- M pywikibot/page.py 1 file changed, 4 insertions(+), 7 deletions(-)
Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified
diff --git a/pywikibot/page.py b/pywikibot/page.py index 446bbe0..8abf390 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -3618,7 +3618,7 @@ @type force: bool @param args: values of props """ - super(ItemPage, self).get(force=force, *args, **kwargs) + data = super(ItemPage, self).get(force=force, *args, **kwargs)
# claims self.claims = {} @@ -3637,12 +3637,9 @@ self.sitelinks[dbname] = self._content[ 'sitelinks'][dbname]['title']
- return {'aliases': self.aliases, - 'labels': self.labels, - 'descriptions': self.descriptions, - 'sitelinks': self.sitelinks, - 'claims': self.claims - } + data['claims'] = self.claims + data['sitelinks'] = self.sitelinks + return data
def getRedirectTarget(self): """Return the redirect target for this page."""
pywikibot-commits@lists.wikimedia.org