jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/381626 ) Change subject: harvest_template.py: Fix argument parsing ...................................................................... harvest_template.py: Fix argument parsing The argument parsing would silently drop the next argument following a (template_parameter PID) pair. Bug: T177166 Change-Id: Ic1636bee1cce2b1633a1fbd00ff1ff8f51650b1f --- M scripts/harvest_template.py 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Matěj Suchánek: Looks good to me, but someone else must approve jenkins-bot: Verified Xqt: Looks good to me, approved Zoranzoki21: Looks good to me, but someone else must approve diff --git a/scripts/harvest_template.py b/scripts/harvest_template.py index 9d76d23..2d797b9 100755 --- a/scripts/harvest_template.py +++ b/scripts/harvest_template.py @@ -358,10 +358,9 @@ handler = PropertyOptionHandler(**current_args[2]) fields[current_args[0]] = (current_args[1], handler) del current_args[:] - else: - current_args.append(arg) - if len(current_args) == 2: - current_args.append({}) + current_args.append(arg) + if len(current_args) == 2: + current_args.append({}) # handle leftover if len(current_args) == 3: -- To view, visit https://gerrit.wikimedia.org/r/381626 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1636bee1cce2b1633a1fbd00ff1ff8f51650b1f Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Danmichaelo &lt;danmichaelo(a)gmail.com&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Magul &lt;tomasz.magulski(a)gmail.com&gt; Gerrit-Reviewer: Matěj Suchánek &lt;matejsuchanek97(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: Zoranzoki21 &lt;zorandori4444(a)gmail.com&gt; Gerrit-Reviewer: jenkins-bot <>