jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/363006 )
Change subject: [bugfix] Don't fail TestProofreadPageValidSite.test_url_image
......................................................................
[bugfix] Don't fail TestProofreadPageValidSite.test_url_image
TestProofreadPageValidSite.test_url_image requires bs4 package.
Don't fail tests with TypeError but skip tests when BeautifulSoup is missing
Bug: T169542
Change-Id: I45e08d5dd080b3089c050af87a85826e655dd58d
---
M tests/proofreadpage_tests.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Dalba: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/proofreadpage_tests.py b/tests/proofreadpage_tests.py
index 0e17ae1..77117ad 100644
--- a/tests/proofreadpage_tests.py
+++ b/tests/proofreadpage_tests.py
@@ -1,7 +1,7 @@
# -*- coding: utf-8 -*-
"""Tests for the proofreadpage module."""
#
-# (C) Pywikibot team, 2015-2016
+# (C) Pywikibot team, 2015-2017
#
# Distributed under the terms of the MIT license.
#
@@ -283,6 +283,7 @@
page_text = page._page_to_json()
self.assertEqual(json.loads(page_text), json.loads(loaded_text))
+ @require_modules('bs4')
def test_url_image(self):
"""Test fetching of url image of the scan of
ProofreadPage."""
page = ProofreadPage(self.site, self.valid['title'])
--
To view, visit
https://gerrit.wikimedia.org/r/363006
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45e08d5dd080b3089c050af87a85826e655dd58d
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>