jenkins-bot has submitted this change and it was merged. Change subject: Don't use set literals in tests ...................................................................... Don't use set literals in tests Set literals are not available in Python 2.6. This doesn't change the fact that the tests don't work on 2.6 but at least it stops the message about illegal syntax popping up every time one installs the module. Change-Id: I9b8674af99bc3acd418b2a378679e7254e1dee79 --- M tests/page_tests.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Merlijn van Deen: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/page_tests.py b/tests/page_tests.py index 48f40fe..5a60678 100644 --- a/tests/page_tests.py +++ b/tests/page_tests.py @@ -253,9 +253,9 @@ if not site.hasExtension('Disambiguator', False): raise unittest.SkipTest('Disambiguator extension not loaded on test site') pg = pywikibot.Page(site, 'Random') - pg._pageprops = {'disambiguation', ''} + pg._pageprops = set(['disambiguation', '']) self.assertTrue(pg.isDisambig()) - pg._pageprops = {} + pg._pageprops = set() self.assertFalse(pg.isDisambig()) def testReferences(self): -- To view, visit https://gerrit.wikimedia.org/r/86433 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b8674af99bc3acd418b2a378679e7254e1dee79 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Mineo <themineo(a)gmail.com> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: jenkins-bot