Hello PywikibotCommitWatcher,

I'd like you to do a code review. Please visit

https://gerrit.wikimedia.org/r/76352

to review the following change.

Change subject: improvement; add httplib2 as submodule - setuptools still missing ......................................................................

improvement; add httplib2 as submodule - setuptools still missing

Change-Id: Iec4e2a4525185890546663c8702ad17370fee70c --- M .gitmodules A externals/httplib2 M scripts/blockpageschecker.py M scripts/harvest_template.py M scripts/redirect.py M scripts/tests/test_data_ingestion.py M scripts/tests/test_utils.py M tests/textlib_tests.py 8 files changed, 9 insertions(+), 6 deletions(-)

git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core refs/changes/52/76352/1

diff --git a/.gitmodules b/.gitmodules index 8daccd1..f862971 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,3 +1,6 @@ [submodule "i18n"] path = scripts/i18n url = https://gerrit.wikimedia.org/r/p/pywikibot/i18n.git +[submodule "externals/httplib2"] + path = externals/httplib2 + url = https://github.com/iserko/httplib2.git diff --git a/externals/httplib2 b/externals/httplib2 new file mode 160000 index 0000000..989028e --- /dev/null +++ b/externals/httplib2 +Subproject commit 989028e51d283d04b46884b666d2ccde6452304f diff --git a/scripts/blockpageschecker.py b/scripts/blockpageschecker.py index 63a891a..8d8f23e 100755 --- a/scripts/blockpageschecker.py +++ b/scripts/blockpageschecker.py @@ -61,7 +61,7 @@ # # Distributed under the terms of the MIT license. # -__version__ = '$Id: blockpageschecker.py,v 1.5 2008/04/24 19.40.00 filnik Exp$' +__version__ = '$Id$' #

import re, webbrowser diff --git a/scripts/harvest_template.py b/scripts/harvest_template.py index 3a187f0..c78b97a 100755 --- a/scripts/harvest_template.py +++ b/scripts/harvest_template.py @@ -19,7 +19,7 @@ # # Distributed under the terms of MIT License. # -__version__ = '$Id: harvest_template.py 11692 2013-06-24 16:55:46Z xqt $' +__version__ = '$Id$' #

import re diff --git a/scripts/redirect.py b/scripts/redirect.py index 5082447..bf42437 100755 --- a/scripts/redirect.py +++ b/scripts/redirect.py @@ -56,7 +56,7 @@ # # Distributed under the terms of the MIT license. # -__version__='$Id: redirect.py 7789 2009-12-17 19:20:12Z xqt $' +__version__='$Id$' # import re import datetime diff --git a/scripts/tests/test_data_ingestion.py b/scripts/tests/test_data_ingestion.py index 346eed6..568a6aa 100644 --- a/scripts/tests/test_data_ingestion.py +++ b/scripts/tests/test_data_ingestion.py @@ -2,7 +2,7 @@ # -*- coding: utf-8 -*-

"""Unit tests for data_ingestion.py""" -__version__ = '$Id: test_userlib.py 9043 2011-03-13 10:25:08Z xqt $' +__version__ = '$Id$'

import os import unittest diff --git a/scripts/tests/test_utils.py b/scripts/tests/test_utils.py index 4899bfb..7895f03 100644 --- a/scripts/tests/test_utils.py +++ b/scripts/tests/test_utils.py @@ -1,7 +1,7 @@ """ Support module for PyWikipediaBot regression tests. """ -__version__ = '$Id: test_utils.py 9197 2011-04-25 08:57:30Z xqt $' +__version__ = '$Id$'

import sys

diff --git a/tests/textlib_tests.py b/tests/textlib_tests.py index 7296581..5a4d3f5 100644 --- a/tests/textlib_tests.py +++ b/tests/textlib_tests.py @@ -4,7 +4,7 @@ # # Distributed under the terms of the MIT license. # -__version__ = '$Id: api_tests.py 8238 2010-06-02 13:50:48Z xqt $' +__version__ = '$Id$'

try: import mwparserfromhell