jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/332336 ) Change subject: [IMPR] Update newitem.py to use WikidataBot.user_edit_entity ...................................................................... [IMPR] Update newitem.py to use WikidataBot.user_edit_entity Bug: T87493 Change-Id: I08151e67aed40ea5481e00efd4580598148fcb1f --- M scripts/newitem.py 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/scripts/newitem.py b/scripts/newitem.py index 9d83d45..27835b9 100755 --- a/scripts/newitem.py +++ b/scripts/newitem.py @@ -20,7 +20,7 @@ """ # # (C) Multichill, 2014 -# (C) Pywikibot team, 2014-2016 +# (C) Pywikibot team, 2014-2017 # # Distributed under the terms of the MIT license. # @@ -42,6 +42,7 @@ def __init__(self, generator, **kwargs): """Only accepts options defined in availableOptions.""" self.availableOptions.update({ + 'always': True, 'lastedit': 7, 'pageage': 21, 'touch': False, @@ -77,6 +78,10 @@ except PageNotSaved: pywikibot.error('Page {0} not saved.'.format( page.title(asLink=True))) + + def _callback(self, page, exc): + if exc is None: + self._touch_page(page) def treat(self, page, item): """Treat page/item.""" @@ -127,12 +132,9 @@ } } - pywikibot.output(summary) - item = pywikibot.ItemPage(page.site.data_repository()) - item.editEntity(data, summary=summary) - # And do a null edit to force update - self._touch_page(page) + self.user_edit_entity(item, data, summary=summary, + callback=self._callback) def main(*args): -- To view, visit https://gerrit.wikimedia.org/r/332336 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08151e67aed40ea5481e00efd4580598148fcb1f Gerrit-PatchSet: 8 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Matěj Suchánek &lt;matejsuchanek97(a)gmail.com&gt; Gerrit-Reviewer: Dalba &lt;dalba.wiki(a)gmail.com&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Magul &lt;tomasz.magulski(a)gmail.com&gt; Gerrit-Reviewer: Matěj Suchánek &lt;matejsuchanek97(a)gmail.com&gt; Gerrit-Reviewer: Multichill &lt;maarten(a)mdammers.nl&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: jenkins-bot <>