jenkins-bot has submitted this change and it was merged.
Change subject: Close connection after every request in test_https_cert_error.
......................................................................
Close connection after every request in test_https_cert_error.
Hanging connection create unexpected warning during another request to the
same host.
Bug: T151248
Change-Id: I5c2d2b4461eba04df3f4b41a0862b574d404af82
---
M tests/http_tests.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/http_tests.py b/tests/http_tests.py
index ea1b3cb..35d705f 100644
--- a/tests/http_tests.py
+++ b/tests/http_tests.py
@@ -131,6 +131,7 @@
self.assertRaises(pywikibot.FatalServerError,
http.fetch,
uri='https://testssl-expire-r2i2.disig.sk/index.en.html')
+ http.session.close() # clear the connection
with warnings.catch_warnings(record=True) as warning_log:
response = http.fetch(
@@ -139,12 +140,13 @@
r = response.content
self.assertIsInstance(r, unicode)
self.assertTrue(re.search(r'<title>.*</title>', r))
+ http.session.close() # clear the connection
# Verify that it now fails again
- http.session.close() # but first clear the connection
self.assertRaises(pywikibot.FatalServerError,
http.fetch,
uri='https://testssl-expire-r2i2.disig.sk/index.en.html')
+ http.session.close() # clear the connection
# Verify that the warning occurred
self.assertEqual(len(warning_log), 1)
--
To view, visit
https://gerrit.wikimedia.org/r/322866
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c2d2b4461eba04df3f4b41a0862b574d404af82
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Lokal Profil <lokal.profil(a)gmail.com>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>