jenkins-bot has submitted this change and it was merged.
Change subject: Fix cache username test ......................................................................
Fix cache username test
Change-Id: I069756e9a3a6dbe900b8176cacf97b5f9d37f0d7 --- M tests/cache_tests.py 1 file changed, 2 insertions(+), 3 deletions(-)
Approvals: Nullzero: Looks good to me, approved jenkins-bot: Verified
diff --git a/tests/cache_tests.py b/tests/cache_tests.py index 241f2d7..020dd1e 100644 --- a/tests/cache_tests.py +++ b/tests/cache_tests.py @@ -25,9 +25,8 @@ self.assertIsInstance(entry.site, BaseSite) self.assertIsInstance(entry.site._loginstatus, int) self.assertIsInstance(entry.site._username, list) - print(entry.site._loginstatus, entry.site._username) - self.assertTrue(bool(entry.site._loginstatus < 1) != - bool(entry.site._username[0])) + if entry.site._loginstatus >= 1: + self.assertIsNotNone(entry.site._username[0]) self.assertIsInstance(entry._params, dict) self.assertIsNotNone(entry._params) # TODO: more tests on entry._params, and possibly fixes needed
pywikibot-commits@lists.wikimedia.org