jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/463070 )

Change subject: [cleanup] cleanup tests/xmlreader_tests.py ......................................................................

[cleanup] cleanup tests/xmlreader_tests.py

- remove preleading "u" from strings - use single quotes for string literals

Change-Id: I0b451a613a94146d96d23b6a6031bede87fffb6f --- M tests/xmlreader_tests.py 1 file changed, 9 insertions(+), 9 deletions(-)

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified

diff --git a/tests/xmlreader_tests.py b/tests/xmlreader_tests.py index ade20c9..c2e5403 100644 --- a/tests/xmlreader_tests.py +++ b/tests/xmlreader_tests.py @@ -35,20 +35,20 @@ """Test loading all revisions.""" pages = self._get_entries('article-pear.xml', allrevisions=True) self.assertEqual(4, len(pages)) - self.assertEqual(u"Automated conversion", pages[0].comment) - self.assertEqual(u"Pear", pages[0].title) - self.assertEqual(u"24278", pages[0].id) + self.assertEqual('Automated conversion', pages[0].comment) + self.assertEqual('Pear', pages[0].title) + self.assertEqual('24278', pages[0].id) self.assertTrue(pages[0].text.startswith('Pears are [[tree]]s of')) - self.assertEqual(u"Quercusrobur", pages[1].username) - self.assertEqual(u"Pear", pages[0].title) + self.assertEqual('Quercusrobur', pages[1].username) + self.assertEqual('Pear', pages[0].title)

def test_XmlDumpFirstRev(self): """Test loading the first revision.""" - pages = self._get_entries("article-pear.xml", allrevisions=False) + pages = self._get_entries('article-pear.xml', allrevisions=False) self.assertEqual(1, len(pages)) - self.assertEqual(u"Automated conversion", pages[0].comment) - self.assertEqual(u"Pear", pages[0].title) - self.assertEqual(u"24278", pages[0].id) + self.assertEqual('Automated conversion', pages[0].comment) + self.assertEqual('Pear', pages[0].title) + self.assertEqual('24278', pages[0].id) self.assertTrue(pages[0].text.startswith('Pears are [[tree]]s of')) self.assertTrue(not pages[0].isredirect)