jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/516486 )
Change subject: [cleanup] use_image_name parameter was deprecated months ago
......................................................................
[cleanup] use_image_name parameter was deprecated months ago
use_image_name parameter of Namepace.builtin_namespaces is deprecated
and has no functionality anymore. It can be removed from tests to
suppress deprecation warnings.
Change-Id: I4e6a92aa88f4c7868f745d6600a9331ea9da2a3a
---
M tests/namespace_tests.py
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Dvorapa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/namespace_tests.py b/tests/namespace_tests.py
index 6d563e8..d2db0c8 100644
--- a/tests/namespace_tests.py
+++ b/tests/namespace_tests.py
@@ -64,7 +64,7 @@
def testNamespaceTypes(self):
"""Test cases for methods manipulating Namespace
names."""
- ns = Namespace.builtin_namespaces(use_image_name=False)
+ ns = Namespace.builtin_namespaces()
self.assertIsInstance(ns, dict)
self.assertTrue(all(x in ns for x in range(0, 16)))
@@ -116,7 +116,7 @@
def testNamespaceToString(self):
"""Test Namespace __str__ and __unicode__."""
- ns = Namespace.builtin_namespaces(use_image_name=False)
+ ns = Namespace.builtin_namespaces()
self.assertEqual(str(ns[0]), ':')
self.assertEqual(str(ns[1]), 'Talk:')
@@ -250,7 +250,7 @@
def test_resolve_equal(self):
"""Test Namespace.resolve success."""
- namespaces = Namespace.builtin_namespaces(use_image_name=False)
+ namespaces = Namespace.builtin_namespaces()
main_ns = namespaces[0]
file_ns = namespaces[6]
special_ns = namespaces[-1]
@@ -334,7 +334,7 @@
def test_set(self):
"""Test converting sequence of Namespace to a
set."""
- namespaces = Namespace.builtin_namespaces(use_image_name=False)
+ namespaces = Namespace.builtin_namespaces()
self.assertTrue(all(isinstance(x, int) for x in namespaces))
self.assertTrue(all(isinstance(x, int) for x in namespaces.keys()))
@@ -348,7 +348,7 @@
def test_set_minus(self):
"""Test performing set minus operation on set of Namespace
objects."""
- namespaces = Namespace.builtin_namespaces(use_image_name=False)
+ namespaces = Namespace.builtin_namespaces()
excluded_namespaces = {-1, -2}
--
To view, visit
https://gerrit.wikimedia.org/r/516486
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e6a92aa88f4c7868f745d6600a9331ea9da2a3a
Gerrit-Change-Number: 516486
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: jenkins-bot (75)