jenkins-bot has submitted this change and it was merged.
Change subject: pagegenerators.py: use explicit list instead of map()
......................................................................
pagegenerators.py: use explicit list instead of map()
In python3 map() will create a <map object>, which will be emptied after
first use. Second comparison will throw an error.
Use explicitly a list instead.
Bug: T151237
Change-Id: I1ff53a90e2e3c06e079a82387ae186fc8f3215e0
---
M pywikibot/pagegenerators.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Magul: Looks good to me, but someone else must approve
Dalba: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py
index d4677e7..748d09d 100644
--- a/pywikibot/pagegenerators.py
+++ b/pywikibot/pagegenerators.py
@@ -849,7 +849,7 @@
if not self.site.has_extension('ProofreadPage'):
raise UnknownExtension(
'Ql filtering needs a site with ProofreadPage extension.')
- value = map(int, value.split(','))
+ value = [int(_) for _ in value.split(',')]
if min(value) < 0 or max(value) > 4: # Invalid input ql.
valid_ql = ['{0}: {1}'.format(*i) for
i in self.site.proofread_levels.items()]
--
To view, visit
https://gerrit.wikimedia.org/r/322415
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ff53a90e2e3c06e079a82387ae186fc8f3215e0
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>