jenkins-bot has submitted this change and it was merged.
Change subject: Allow both upper- and lowercase wikibase IDs ......................................................................
Allow both upper- and lowercase wikibase IDs
Change-Id: Id7c29981e8dde7c041a16b43bcc2658faf7b0c94 --- M pywikibot/site.py 1 file changed, 10 insertions(+), 1 deletion(-)
Approvals: Aude: Looks good to me, but someone else must approve Legoktm: Looks good to me, approved jenkins-bot: Verified
diff --git a/pywikibot/site.py b/pywikibot/site.py index 43ec1df..17566e9 100644 --- a/pywikibot/site.py +++ b/pywikibot/site.py @@ -3515,7 +3515,16 @@ #Store it for 100 years req = api.CachedRequest(expiry, site=self, **params) data = req.submit() - dtype = data['entities'][prop.getID()]['datatype'] + + # the IDs returned from the API can be upper or lowercase, depending + # on the version. See for more information: + # https://bugzilla.wikimedia.org/show_bug.cgi?id=53894 + # http://lists.wikimedia.org/pipermail/wikidata-tech/2013-September/000296.htm... + try: + dtype = data['entities'][prop.getID()]['datatype'] + except KeyError: + dtype = data['entities'][prop.getID().lower()]['datatype'] + if dtype == 'globe-coordinate': dtype = 'globecoordinate' #TODO Fix this
pywikibot-commits@lists.wikimedia.org