XZise has submitted this change and it was merged.
Change subject: MySQLPageGenerator fails due to wrong classname
......................................................................
MySQLPageGenerator fails due to wrong classname
The generator tries to compare against pywikibot.site.Site,
which doesnt exist. Use BaseSite instead.
Bug introduced in Aug 2013 - 2e35403.
Bug: 72127
Change-Id: I4876b53baebf656e196682c203c45e65551f200e
---
M pywikibot/pagegenerators.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
XZise: Looks good to me, approved
diff --git a/pywikibot/pagegenerators.py b/pywikibot/pagegenerators.py
index ea34ddd..f6e3687 100644
--- a/pywikibot/pagegenerators.py
+++ b/pywikibot/pagegenerators.py
@@ -1448,7 +1448,7 @@
import MySQLdb as mysqldb
if site is None:
site = pywikibot.Site()
- if isinstance(site, pywikibot.site.Site):
+ if isinstance(site, pywikibot.site.BaseSite):
# We want to let people to set a custom dbname
# since the master dbname might not be exactly
# equal to the name on the replicated site
--
To view, visit
https://gerrit.wikimedia.org/r/166983
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4876b53baebf656e196682c203c45e65551f200e
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: jenkins-bot <>