saper has submitted this change and it was merged.
Change subject: (bug T63231) use OSError as WindowsError does not exist on unix hosts ......................................................................
(bug T63231) use OSError as WindowsError does not exist on unix hosts
Change-Id: I17d0352a221e68df5b64b324a48bd82e1d76fb65 --- M pywikibot/version.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: saper: Verified; Looks good to me, approved
diff --git a/pywikibot/version.py b/pywikibot/version.py index ee49fe7..55a2ee0 100644 --- a/pywikibot/version.py +++ b/pywikibot/version.py @@ -178,7 +178,7 @@ date = None try: subprocess.Popen([cmd], stdout=subprocess.PIPE).communicate() - except WindowsError: + except OSError: # some windows git versions provide git.cmd instead of git.exe cmd = 'git.cmd' try:
pywikibot-commits@lists.wikimedia.org