jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/430579 )
Change subject: generate_user_files.py: Apply minor code clean-up ......................................................................
generate_user_files.py: Apply minor code clean-up
The global decleration in main function is not needed because base_dir is not used in that function.
Typo: Change (has_userfile or has_userfile) to (has_userfile or has_passfile).
Change-Id: Ia70323fd2b8c336abb8c6b6f28c00d1ab7c6986e --- M generate_user_files.py 1 file changed, 1 insertion(+), 3 deletions(-)
Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
diff --git a/generate_user_files.py b/generate_user_files.py index 77bd611..a07abdf 100755 --- a/generate_user_files.py +++ b/generate_user_files.py @@ -414,8 +414,6 @@ @param args: command line arguments @type args: list of unicode """ - global base_dir - # set the config family and mylang values to an invalid state so that # the script can detect that the command line arguments -family & -lang # were used and and handle_args has updated these config values, @@ -440,7 +438,7 @@
try: has_userfile, has_passfile = ask_for_dir_change(force) - if not (has_userfile or has_userfile): + if not (has_userfile or has_passfile): create_user_config(config.family, config.mylang, username, force=force) except KeyboardInterrupt:
pywikibot-commits@lists.wikimedia.org