Xqt has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/768164
)
Change subject: Revert "Skip TestIndexPageMappings and test_url_image"
......................................................................
Revert "Skip TestIndexPageMappings and test_url_image"
This reverts commit f1a1678345f79dccd018e2ab68111b5bae71c1bf.
Reason for revert:
T181913 works after GoogleOCR url was updated in previous commit,
T114318 was already solved
Bug: T181913
Change-Id: Ic630fc77231ed7c1c52e077a6e2c5f0537a50fc9
---
M tests/proofreadpage_tests.py
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/tests/proofreadpage_tests.py b/tests/proofreadpage_tests.py
index 627a7136..5da3841 100755
--- a/tests/proofreadpage_tests.py
+++ b/tests/proofreadpage_tests.py
@@ -305,7 +305,6 @@
self.assertEqual(json.loads(page_text), json.loads(loaded_text))
@require_modules('bs4')
- @unittest.skip('T181913 and T114318')
def test_url_image(self):
"""Test fetching of url image of the scan of
ProofreadPage."""
page = ProofreadPage(self.site, self.valid['title'])
@@ -615,7 +614,6 @@
references='<references/>', div_end=div)
-(a)unittest.skip('T181913 and T114318')
class TestIndexPageMappings(BS4TestCase):
"""Test IndexPage class."""
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/768164
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: Ic630fc77231ed7c1c52e077a6e2c5f0537a50fc9
Gerrit-Change-Number: 768164
Gerrit-PatchSet: 4
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged