jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/606073 ) Change subject: [cleanup] replace _winreg by winreg ...................................................................... [cleanup] replace _winreg by winreg replace _winreg variable by winreg. _winreg was intended to hold it due to a clean git blame but the whole section was inserted anyway. Change-Id: Ie052aab56c9a008430bd6691df9088f48507af8d --- M pywikibot/config2.py 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Dvorapa: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/config2.py b/pywikibot/config2.py index d57ed60..e57eb83 100644 --- a/pywikibot/config2.py +++ b/pywikibot/config2.py @@ -947,13 +947,12 @@ fileexts_key = \ r'Software\Microsoft\Windows\CurrentVersion\Explorer\FileExts' key_name = fileexts_key + r'\.' + extension + r'\OpenWithProgids' - _winreg = winreg # exists for git blame only; do not use try: key1 = winreg.OpenKey(winreg.HKEY_CURRENT_USER, key_name) _prog_id = winreg.EnumValue(key1, 0)[0] - _key2 = _winreg.OpenKey(_winreg.HKEY_CLASSES_ROOT, - r'%s\shell\open\command' % _prog_id) - _cmd = _winreg.QueryValueEx(_key2, None)[0] + _key2 = winreg.OpenKey(winreg.HKEY_CLASSES_ROOT, + r'{}\shell\open\command'.format(_prog_id)) + _cmd = winreg.QueryValueEx(_key2, None)[0] # See T102465 for issues relating to using this value. cmd = _cmd if cmd.find('%1'): -- To view, visit https://gerrit.wikimedia.org/r/606073 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie052aab56c9a008430bd6691df9088f48507af8d Gerrit-Change-Number: 606073 Gerrit-PatchSet: 2 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: jenkins-bot (75)