jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/681782 )
Change subject: [bugfix] Fix nowcommons test failure ......................................................................
[bugfix] Fix nowcommons test failure
By moving the nowcommons script in commit fd16ca1ff it got unit test coverage. Fixing its test failure...
% python -m tests.script_tests TestScriptSimulate ... ====================================================================== FAIL: test_nowcommons (tests.script_tests.TestScriptSimulate) Test running nowcommons -simulate. ---------------------------------------------------------------------- Traceback (most recent call last): File "pywikibot/tests/script_tests.py", line 243, in testScript self.assertIn('Use -help for further information.', AssertionError: 'Use -help for further information.' not found in ['No transcluded files found for NowCommons.', '', '0 pages read', '0 pages written', '0 pages skipped', 'Script terminated successfully.']
----------------------------------------------------------------------
Change-Id: If504d72e3e67a31b3fb3d32fcb36a17deb40752d --- M tests/script_tests.py 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
diff --git a/tests/script_tests.py b/tests/script_tests.py index 4e7cb11..9572dc1 100644 --- a/tests/script_tests.py +++ b/tests/script_tests.py @@ -103,6 +103,7 @@ # script_input['interwiki'] above lists a title that should not exist 'interwiki': 'does not exist. Skipping.', 'login': 'Logged in on ', + 'nowcommons': 'No transcluded files found for NowCommons.', 'pagefromfile': 'Please enter the file name', 'parser_function_count': 'Hold on, this will need some time.', 'replace': 'Press Enter to use this automatic message',
pywikibot-commits@lists.wikimedia.org