jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/488067 ) Change subject: download_dump: Handle `get_dump_name()` if there are non-number dirnames ...................................................................... download_dump: Handle `get_dump_name()` if there are non-number dirnames Handle `get_dump_name()` if there are non-number dirnames like 'latest', etc. Bug: T184032 Change-Id: If0a39ab4e5f080ebe1963d61c9c9a6f6cdb11574 --- M scripts/maintenance/download_dump.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: ArielGlenn: Looks good to me, but someone else must approve Dvorapa: Looks good to me, but someone else must approve Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/maintenance/download_dump.py b/scripts/maintenance/download_dump.py index 8347a7a..66c96fc 100644 --- a/scripts/maintenance/download_dump.py +++ b/scripts/maintenance/download_dump.py @@ -66,7 +66,9 @@ """Check if dump file exists locally in a Toolforge server.""" db_path = '/public/dumps/public/{0}/'.format(db_name) if os.path.isdir(db_path): - dates = map(int, os.listdir(db_path)) + dirs = [directory for directory in os.listdir(db_path) if + directory.isdigit()] + dates = map(int, dirs) dates = sorted(dates, reverse=True) for date in dates: dump_filepath = ('/public/dumps/public/{0}/{1}/{2}-{3}-{4}' -- To view, visit https://gerrit.wikimedia.org/r/488067 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If0a39ab4e5f080ebe1963d61c9c9a6f6cdb11574 Gerrit-Change-Number: 488067 Gerrit-PatchSet: 2 Gerrit-Owner: Rafidaslam <rafidteam(a)gmail.com> Gerrit-Reviewer: ArielGlenn <ariel(a)wikimedia.org> Gerrit-Reviewer: D3r1ck01 <alangiderick(a)gmail.com> Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz> Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot (75)