jenkins-bot has submitted this change and it was merged.
Change subject: [IMPROV] Archivebot tests: Use assertIsInstance
......................................................................
[IMPROV] Archivebot tests: Use assertIsInstance
Change-Id: I60856037297c4d064aebd755ec967cb9eaff4a3e
---
M tests/archivebot_tests.py
1 file changed, 12 insertions(+), 13 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/archivebot_tests.py b/tests/archivebot_tests.py
index d5e958e..ba1a8ca 100644
--- a/tests/archivebot_tests.py
+++ b/tests/archivebot_tests.py
@@ -39,30 +39,29 @@
site = self.get_site(code)
page = pywikibot.Page(site, 'user talk:xqt')
talk = archivebot.DiscussionPage(page, None)
- self.assertTrue(isinstance(talk.archives, dict))
- self.assertTrue(isinstance(talk.archived_threads, int))
+ self.assertIsInstance(talk.archives, dict)
+ self.assertIsInstance(talk.archived_threads, int)
self.assertTrue(talk.archiver is None)
- self.assertTrue(isinstance(talk.header, basestring))
- self.assertTrue(isinstance(talk.timestripper, TimeStripper))
+ self.assertIsInstance(talk.header, basestring)
+ self.assertIsInstance(talk.timestripper, TimeStripper)
- self.assertTrue(isinstance(talk.threads, list))
+ self.assertIsInstance(talk.threads, list)
self.assertGreaterEqual(
len(talk.threads), THREADS[code],
u'%d Threads found on %s,\n%d or more expected'
% (len(talk.threads), talk, THREADS[code]))
for thread in talk.threads:
- self.assertTrue(isinstance(thread,
- archivebot.DiscussionThread))
- self.assertTrue(isinstance(thread.title, basestring))
- self.assertTrue(isinstance(thread.now, datetime))
+ self.assertIsInstance(thread, archivebot.DiscussionThread)
+ self.assertIsInstance(thread.title, basestring)
+ self.assertIsInstance(thread.now, datetime)
self.assertEqual(thread.now, talk.now)
- self.assertTrue(isinstance(thread.ts, TimeStripper))
+ self.assertIsInstance(thread.ts, TimeStripper)
self.assertEqual(thread.ts, talk.timestripper)
- self.assertTrue(isinstance(thread.code, basestring))
+ self.assertIsInstance(thread.code, basestring)
self.assertEqual(thread.code, talk.timestripper.site.code)
- self.assertTrue(isinstance(thread.content, basestring))
- self.assertTrue(isinstance(thread.timestamp, datetime))
+ self.assertIsInstance(thread.content, basestring)
+ self.assertIsInstance(thread.timestamp, datetime)
expected_failures = ['ar', 'ckb', 'fa', 'pdc',
'th']
# expected failures - should be fixed
--
To view, visit
https://gerrit.wikimedia.org/r/160250
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60856037297c4d064aebd755ec967cb9eaff4a3e
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: jenkins-bot <>