jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/599305 )
Change subject: Drop redundant code ......................................................................
Drop redundant code
The same routine happens in Claim.on_item.setter, so it's redundant to do it again.
Change-Id: If36a5072a4b3582ca5eafe2d48b50dd5960fa960 --- M pywikibot/page/__init__.py 1 file changed, 0 insertions(+), 7 deletions(-)
Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
diff --git a/pywikibot/page/__init__.py b/pywikibot/page/__init__.py index 9d46cc3..9085f15 100644 --- a/pywikibot/page/__init__.py +++ b/pywikibot/page/__init__.py @@ -4616,13 +4616,6 @@ 'The provided Claim instance is already used in an entity') self.repo.addClaim(self, claim, bot=bot, **kwargs) claim.on_item = self - for snaks in claim.qualifiers.values(): - for snak in snaks: - snak.on_item = self - for source in claim.sources: - for snaks in source.values(): - for snak in snaks: - snak.on_item = self
def removeClaims(self, claims, **kwargs): """
pywikibot-commits@lists.wikimedia.org