jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/371771 )
Change subject: exceptions.py: Let Server504Error and Server414Error inherit from
ServerError
......................................................................
exceptions.py: Let Server504Error and Server414Error inherit from ServerError
This is potentially a breaking change, but it makes sense and hopefully nobody
relies on catching a `ServerError` without catching `Server414Error` or
`Server504Error`.
Bug: T173289
Change-Id: I5f068886442d55aa0072815f4edbffbefa3577ae
---
M pywikibot/exceptions.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/pywikibot/exceptions.py b/pywikibot/exceptions.py
index d9dff19..2914eb7 100644
--- a/pywikibot/exceptions.py
+++ b/pywikibot/exceptions.py
@@ -464,14 +464,14 @@
pass
-class Server504Error(Error): # noqa
+class Server504Error(ServerError): # noqa
"""Server timed out with HTTP 504 code"""
pass
-class Server414Error(Error):
+class Server414Error(ServerError):
"""Server returned with HTTP 414 code."""
--
To view, visit
https://gerrit.wikimedia.org/r/371771
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f068886442d55aa0072815f4edbffbefa3577ae
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>