Hello PywikibotCommitWatcher,

I'd like you to do a code review. Please visit

https://gerrit.wikimedia.org/r/237622

to review the following change.

Change subject: Add _isempty caching attribute to Page ......................................................................

Add _isempty caching attribute to Page

Page.IsEmpty() is a somewhat heavy function and can be called several times for the same page. interwiki.py, for instance, does that. Adding the attribute _isempty allows caching of this value without the need for re-evaluation. The attribute is cleared when latest_revision_id is deleted for safety sake.

Change-Id: Ib68446a77f52f59440d9f50fef416b9bfdb39827 --- M pywikibot/page.py 1 file changed, 8 insertions(+), 5 deletions(-)

git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core refs/changes/22/237622/1

diff --git a/pywikibot/page.py b/pywikibot/page.py index 2ba2b0c..d0cd3a3 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -456,7 +456,7 @@ # * Old exceptions do not apply any more # * Deleting _revid to force reload # * Deleting _redirtarget, that info is now obsolete. - for attr in ['_redirtarget', '_getexception', '_revid']: + for attr in ['_redirtarget', '_getexception', '_revid', '_isempty']: if hasattr(self, attr): delattr(self, attr)

@@ -738,10 +738,13 @@

@rtype: bool """ - txt = self.get() - txt = textlib.removeLanguageLinks(txt, site=self.site) - txt = textlib.removeCategoryLinks(txt, site=self.site) - return len(txt) < 4 + if not hasattr(self, "_isempty"): + txt = self.get() + txt = textlib.removeLanguageLinks(txt, site=self.site) + txt = textlib.removeCategoryLinks(txt, site=self.site) + self._isempty = len(txt) < 4 + + return bool(self._isempty)

def isTalkPage(self): """Return True if this page is in any talk namespace."""