jenkins-bot has submitted this change and it was merged.
Change subject: [FIX] win32_unicode: Adjust UnicodeOutput to IOBase
......................................................................
[FIX] win32_unicode: Adjust UnicodeOutput to IOBase
With 72afc93e the `UnicodeOutput` class subclasses `IOBase` which already
handles `closed`, `close()` and `isatty()`.
Change-Id: Ifc78ba65198bf9add0bf239f5faba711366dd573
---
M pywikibot/userinterfaces/win32_unicode.py
1 file changed, 0 insertions(+), 10 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/userinterfaces/win32_unicode.py
b/pywikibot/userinterfaces/win32_unicode.py
index f86185b..74b60c3 100755
--- a/pywikibot/userinterfaces/win32_unicode.py
+++ b/pywikibot/userinterfaces/win32_unicode.py
@@ -96,21 +96,11 @@
self._hConsole = hConsole
self._stream = stream
self._fileno = fileno
- self.closed = False
self.softspace = False
self.mode = 'w'
self.encoding = 'utf-8'
self.name = name
self.flush()
-
- def isatty(self):
- """Return whether it's a tty."""
- return False
-
- def close(self):
- """Set the stream to be closed."""
- # don't really close the handle, that would only cause problems
- self.closed = True
def fileno(self):
"""Return the fileno."""
--
To view, visit
https://gerrit.wikimedia.org/r/239750
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc78ba65198bf9add0bf239f5faba711366dd573
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>