jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/606746 )
Change subject: [IMPR] use subTest for TestTranslate.test_localized
......................................................................
[IMPR] use subTest for TestTranslate.test_localized
Also follow PEP 8 naming convention for this test class
Change-Id: I5adccd5a1225185270d131be1e5a04d3c2005e63
---
M tests/i18n_tests.py
1 file changed, 8 insertions(+), 12 deletions(-)
Approvals:
Dvorapa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/i18n_tests.py b/tests/i18n_tests.py
index 6e21cbe..2f0e164 100644
--- a/tests/i18n_tests.py
+++ b/tests/i18n_tests.py
@@ -35,19 +35,15 @@
self.msg_no_english = {'ja': 'test-no-english JA'}
super(TestTranslate, self).setUp()
- def testLocalized(self):
+ def test_localized(self):
"""Test fully localized translations."""
- self.assertEqual(i18n.translate('en', self.msg_localized,
- fallback=True),
- 'test-localized EN')
- self.assertEqual(i18n.translate('nl', self.msg_localized,
- fallback=True),
- 'test-localized NL')
- self.assertEqual(i18n.translate('fy', self.msg_localized,
- fallback=True),
- 'test-localized FY')
+ for code, msg in self.msg_localized.items():
+ with self.subTest(code=code):
+ self.assertEqual(i18n.translate(code, self.msg_localized,
+ fallback=True),
+ msg)
- def testSemiLocalized(self):
+ def test_semi_localized(self):
"""Test translate by fallback to an alternative
language."""
self.assertEqual(i18n.translate('en', self.msg_semi_localized,
fallback=True),
@@ -58,7 +54,7 @@
fallback=True),
'test-semi-localized NL')
- def testNonLocalized(self):
+ def test_non_localized(self):
"""Test translate with missing localisation."""
for code in ('en', 'fy', 'nl', 'ru'):
with self.subTest(code=code):
--
To view, visit
https://gerrit.wikimedia.org/r/606746
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5adccd5a1225185270d131be1e5a04d3c2005e63
Gerrit-Change-Number: 606746
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dvorapa <dvorapa(a)seznam.cz>
Gerrit-Reviewer: Isaacandy <isaac(a)iznd.xyz>
Gerrit-Reviewer: Siebrand <siebrand(a)kitano.nl>
Gerrit-Reviewer: jenkins-bot (75)