jenkins-bot has submitted this change and it was merged.
Change subject: workaround: restore CategoryMoveRobot.oldcat after move
......................................................................
workaround: restore CategoryMoveRobot.oldcat after move
pywikibot.data.api.update_page would otherwise make oldcat point to
newcat, making CategoryMoveRobot._change() almost useless.
I would surely welcome a more thorough solution.
Change-Id: I8842fbba10c9026a9087dfb1503708644f2992fd
---
M scripts/category.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/category.py b/scripts/category.py
index 3923ca0..f7fcbcb 100755
--- a/scripts/category.py
+++ b/scripts/category.py
@@ -470,8 +470,10 @@
"""
if self.newcat and self.move_oldcat and not self.newcat.exists():
if "move-categorypages" in self.site.userinfo["rights"]:
+ oldcattitle = self.oldcat.title()
self.oldcat.move(self.newcat.title(), reason=self.comment,
movetalkpage=True)
+ self.oldcat = pywikibot.Category(self.oldcat.site, oldcattitle)
else:
self._movecat()
self._movetalk()
--
To view, visit
https://gerrit.wikimedia.org/r/149608
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8842fbba10c9026a9087dfb1503708644f2992fd
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <ricordisamoa(a)openmailbox.org>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: jenkins-bot <>