jenkins-bot has submitted this change and it was merged.
Change subject: Improve comment in page_tests.testBasePageConstructor ......................................................................
Improve comment in page_tests.testBasePageConstructor
Comment in page_tests.testBasePageConstructor was misleading, now fixed.
Change-Id: Iaa3254f56c35dc8e10a4051f374c55e7c0f2a1d4 --- M tests/page_tests.py 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Nullzero: Looks good to me, approved jenkins-bot: Verified
diff --git a/tests/page_tests.py b/tests/page_tests.py index 98616e5..460f1e8 100644 --- a/tests/page_tests.py +++ b/tests/page_tests.py @@ -281,8 +281,8 @@ site = self.get_site()
# Should not raise an error as the constructor only requires - # the site parameter, with the title parameter defaulted to - # empty string + # the site parameter. + # Empty string or None as title raises error. page = pywikibot.page.BasePage(site) self.assertRaises(InvalidTitle, page.title) page = pywikibot.page.BasePage(site, title=u'')
pywikibot-commits@lists.wikimedia.org