jenkins-bot has submitted this change and it was merged.
Change subject: [IMPROV] nowcommons: Query at most one users ......................................................................
[IMPROV] nowcommons: Query at most one users
To verify if a page is used it's only necessary to query one using page instead of all.
Conflicts: scripts/nowcommons.py
Change-Id: I9bbb206ede1723c33410c3b50e05dae71ecc265f --- M scripts/nowcommons.py 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified
diff --git a/scripts/nowcommons.py b/scripts/nowcommons.py index b462ec7..3e4e5b7 100755 --- a/scripts/nowcommons.py +++ b/scripts/nowcommons.py @@ -369,9 +369,9 @@ oImageRobot.run() # If the image is used with the urlname the # previous function won't work - if len(list(pywikibot.FilePage(self.site, - page.title()).usingPages())) > 0 and \ - self.getOption('replaceloose'): + is_used = bool(list(pywikibot.FilePage( + self.site, page.title()).usingPages(total=1))) + if is_used and self.getOption('replaceloose'): oImageRobot = image.ImageRobot( pg.FileLinksGenerator( localImagePage),
pywikibot-commits@lists.wikimedia.org