jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/704637 )
Change subject: [cleanup] Explicitly return None from ContextOption.result() ......................................................................
[cleanup] Explicitly return None from ContextOption.result()
According to Xqt this method's pydoc is outdated and returning None is the correct behavior [1]. This doesn't change anything - just minor cleanup.
[1] https://gerrit.wikimedia.org/r/c/pywikibot/core/+/704637
Bug: T286403 Change-Id: Icc979089912bf5b75f2518cef03bc33a5d8b8d63 --- M pywikibot/bot_choice.py 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified
diff --git a/pywikibot/bot_choice.py b/pywikibot/bot_choice.py index 89daa17..59aad26 100755 --- a/pywikibot/bot_choice.py +++ b/pywikibot/bot_choice.py @@ -242,9 +242,9 @@ self.end = end
def result(self, value: str) -> Any: - """Add the delta to the context and output it.""" + """Add the delta to the context.""" self.context += self.delta - super().result(value) + return None
@property def out(self) -> str:
pywikibot-commits@lists.wikimedia.org