jenkins-bot has submitted this change and it was merged. Change subject: [FIX] Replace: Switch 'use_regex' and 'flags' ...................................................................... [FIX] Replace: Switch 'use_regex' and 'flags' In Replacment.compile both parameters have been used the other way around compared to the rest of the script, which also meant that one call could produce erroneous results. Change-Id: Ifa133e3685baa4baffd9f5437f4a720832f49c4f --- M scripts/replace.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/replace.py b/scripts/replace.py index 014e1dd..4de4424 100755 --- a/scripts/replace.py +++ b/scripts/replace.py @@ -178,7 +178,7 @@ self.edit_summary = edit_summary self.default_summary = default_summary - def compile(self, flags, use_regex): + def compile(self, use_regex, flags): # Set the regular aexpression flags flags |= re.UNICODE -- To view, visit https://gerrit.wikimedia.org/r/176059 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa133e3685baa4baffd9f5437f4a720832f49c4f Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise &lt;CommodoreFabianus(a)gmx.de&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Ladsgroup &lt;ladsgroup(a)gmail.com&gt; Gerrit-Reviewer: Merlijn van Deen &lt;valhallasw(a)arctus.nl&gt; Gerrit-Reviewer: jenkins-bot <>