jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/688326 ) Change subject: [len] remove unnecessary len() for boolean result ...................................................................... [len] remove unnecessary len() for boolean result Change-Id: I492b0ff3c13182ca8174867a99985e2ef5cc50bb --- M tests/aspects.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/aspects.py b/tests/aspects.py index 4ad3c4b..f9da3cc 100644 --- a/tests/aspects.py +++ b/tests/aspects.py @@ -700,7 +700,7 @@ if 'family' in dct or 'code' in dct: dct['site'] = True - if (('sites' not in dct or not len(dct['sites'])) + if (('sites' not in dct or not dct['sites']) and 'family' in dct and 'code' in dct and dct['code'] != '*'): # Add entry to self.sites -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/688326 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: I492b0ff3c13182ca8174867a99985e2ef5cc50bb Gerrit-Change-Number: 688326 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt <info(a)gno.de> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged