jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/807119 ) Change subject: [IMPR] Make write actions a module constant ...................................................................... [IMPR] Make write actions a module constant Change-Id: Ib0473465810e66e67cb6b865e95e58a1ebc5906e --- M pywikibot/data/api/_requests.py 1 file changed, 17 insertions(+), 18 deletions(-) Approvals: Matěj Suchánek: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/data/api/_requests.py b/pywikibot/data/api/_requests.py index 9f779ef..dce0f94 100644 --- a/pywikibot/data/api/_requests.py +++ b/pywikibot/data/api/_requests.py @@ -38,6 +38,22 @@ __all__ = ('CachedRequest', 'Request', 'encode_url') +# Actions that imply database updates on the server, used for various +# things like throttling or skipping actions when we're in simulation +# mode +WRITE_ACTIONS = { + 'block', 'clearhasmsg', 'createaccount', 'delete', 'edit', 'emailuser', + 'filerevert', 'flowthank', 'imagerotate', 'import', 'managetags', + 'mergehistory', 'move', 'options', 'patrol', 'protect', 'purge', + 'resetpassword', 'revisiondelete', 'rollback', 'setnotificationtimestamp', + 'setpagelanguage', 'tag', 'thank', 'unblock', 'undelete', 'upload', + 'userrights', 'watch', 'wbcreateclaim', 'wbcreateredirect', 'wbeditentity', + 'wblinktitles', 'wbmergeitems', 'wbremoveclaims', 'wbremovequalifiers', + 'wbremovereferences', 'wbsetaliases', 'wbsetclaim', 'wbsetclaimvalue', + 'wbsetdescription', 'wbsetlabel', 'wbsetqualifier', 'wbsetreference', + 'wbsetsitelink', 'wbladdform', 'wbleditformelements', 'wblmergelexemes', + 'wblremoveform', +} lagpattern = re.compile( r'Waiting for [\w.: ]+: (?P<lag>\d+(?:\.\d+)?) seconds? lagged') @@ -200,24 +216,7 @@ self.action = parameters['action'] self.update(parameters) # also convert all parameter values to lists self._warning_handler = None # type: Optional[Callable[[str, str], Union[Match[str], bool, None]]] # noqa: E501 - # Actions that imply database updates on the server, used for various - # things like throttling or skipping actions when we're in simulation - # mode - self.write = self.action in { - 'block', 'clearhasmsg', 'createaccount', 'delete', 'edit', - 'emailuser', 'filerevert', 'flowthank', 'imagerotate', 'import', - 'managetags', 'mergehistory', 'move', 'options', 'patrol', - 'protect', 'purge', 'resetpassword', 'revisiondelete', 'rollback', - 'setnotificationtimestamp', 'setpagelanguage', 'tag', 'thank', - 'unblock', 'undelete', 'upload', 'userrights', 'watch', - 'wbcreateclaim', 'wbcreateredirect', 'wbeditentity', - 'wblinktitles', 'wbmergeitems', 'wbremoveclaims', - 'wbremovequalifiers', 'wbremovereferences', 'wbsetaliases', - 'wbsetclaim', 'wbsetclaimvalue', 'wbsetdescription', 'wbsetlabel', - 'wbsetqualifier', 'wbsetreference', 'wbsetsitelink', - 'wbladdform', 'wbleditformelements', 'wblmergelexemes', - 'wblremoveform', - } + self.write = self.action in WRITE_ACTIONS # Client side verification that the request is being performed # by a logged in user, and warn if it isn't a config username. if self.write: -- To view, visit https://gerrit.wikimedia.org/r/c/pywikibot/core/+/807119 To unsubscribe, or for help writing mail filters, visit https://gerrit.wikimedia.org/r/settings Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Change-Id: Ib0473465810e66e67cb6b865e95e58a1ebc5906e Gerrit-Change-Number: 807119 Gerrit-PatchSet: 1 Gerrit-Owner: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: Matěj Suchánek &lt;matejsuchanek97(a)gmail.com&gt; Gerrit-Reviewer: jenkins-bot Gerrit-MessageType: merged