jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/462306 )

Change subject: [cleanup] cleanup scripts/states_redirect.py ......................................................................

[cleanup] cleanup scripts/states_redirect.py

- use single quotes for string literals and double quotes with strings that consist of single quotes within them - use str.format(...) instead of modulo for type specifiers in strings - remove preleading "u" from strings

Change-Id: If045d835f9f750706b85582294d2842a27ac700d --- M scripts/states_redirect.py 1 file changed, 12 insertions(+), 11 deletions(-)

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified

diff --git a/scripts/states_redirect.py b/scripts/states_redirect.py index 1701b6d..81f78c8 100755 --- a/scripts/states_redirect.py +++ b/scripts/states_redirect.py @@ -81,23 +81,24 @@ goal = pl.getRedirectTarget().title() if pywikibot.Page(self.site, goal).exists(): pywikibot.output( - u"Not creating %s - redirect already exists." - % goal) + 'Not creating {0} - redirect already exists.' + .format(goal)) else: pywikibot.warning( - u"%s already exists but redirects elsewhere!" - % goal) + '{0} already exists but redirects elsewhere!' + .format(goal)) except pywikibot.IsNotRedirectPage: pywikibot.warning( - u"Page %s already exists and is not a redirect " - u"Please check page!" - % pl.title()) + 'Page {0} already exists and is not a redirect ' + 'Please check page!' + .format(pl.title())) except pywikibot.NoPage: if page.isRedirectPage(): p2 = page.getRedirectTarget() pywikibot.output( - u'Note: goal page is redirect.\nCreating redirect ' - u'to "%s" to avoid double redirect.' % p2.title()) + 'Note: goal page is redirect.\nCreating redirect ' + 'to "{0}" to avoid double redirect.' + .format(p2.title())) else: p2 = page if self.force or pywikibot.input_yn('Create redirect {0}?' @@ -129,11 +130,11 @@ force = True else: pywikibot.warning( - u'argument "%s" not understood; ignoring.' % arg) + 'argument "{0}" not understood; ignoring.'.format(arg))

bot = StatesRedirectBot(start, force) bot.run()

-if __name__ == "__main__": +if __name__ == '__main__': main()