jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/351007 )
Change subject: Fix D300 errors and remove it from flake ignore
......................................................................
Fix D300 errors and remove it from flake ignore
Change-Id: I90dfda9d3cec457744c97e42068fded85cad2275
---
M tests/tools_tests.py
M tox.ini
2 files changed, 7 insertions(+), 8 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/tests/tools_tests.py b/tests/tools_tests.py
index bb57c87..abf00b8 100644
--- a/tests/tools_tests.py
+++ b/tests/tools_tests.py
@@ -765,35 +765,35 @@
super(TestFileShaCalculator, self).setUp()
def test_md5_complete_calculation(self):
- """"Test md5 of complete file."""
+ """Test md5 of complete file."""
res = tools.compute_file_hash(self.filename, sha='md5')
self.assertEqual(res, '5d7265e290e6733e1e2020630262a6f3')
def test_md5_partial_calculation(self):
- """"Test md5 of partial file (1024 bytes)."""
+ """Test md5 of partial file (1024 bytes)."""
res = tools.compute_file_hash(self.filename, sha='md5',
bytes_to_read=1024)
self.assertEqual(res, 'edf6e1accead082b6b831a0a600704bc')
def test_sha1_complete_calculation(self):
- """"Test sha1 of complete file."""
+ """Test sha1 of complete file."""
res = tools.compute_file_hash(self.filename, sha='sha1')
self.assertEqual(res, '1c12696e1119493a625aa818a35c41916ce32d0c')
def test_sha1_partial_calculation(self):
- """"Test sha1 of partial file (1024
bytes)."""
+ """Test sha1 of partial file (1024 bytes)."""
res = tools.compute_file_hash(self.filename, sha='sha1',
bytes_to_read=1024)
self.assertEqual(res, 'e56fa7bd5cfdf6bb7e2d8649dd9216c03e7271e6')
def test_sha224_complete_calculation(self):
- """"Test sha224 of complete file."""
+ """Test sha224 of complete file."""
res = tools.compute_file_hash(self.filename, sha='sha224')
self.assertEqual(
res, '3d350d9d9eca074bd299cb5ffe1b325a9f589b2bcd7ba1c033ab4d33')
def test_sha224_partial_calculation(self):
- """"Test sha224 of partial file (1024
bytes)."""
+ """Test sha224 of partial file (1024 bytes)."""
res = tools.compute_file_hash(self.filename, sha='sha224',
bytes_to_read=1024)
self.assertEqual(
diff --git a/tox.ini b/tox.ini
index df26e44..1684e64 100644
--- a/tox.ini
+++ b/tox.ini
@@ -145,11 +145,10 @@
# E241: multiple spaces after ':'
# E305: expected 2 blank lines after class or function definition
# D413: Missing blank line after last section
-# D300: Use """triple double quotes"""
# D412: No blank lines allowed between a section header and its content
# E731: do not assign a lambda expression, use a def
-ignore =
C401,C402,C405,E402,D105,D211,FI10,FI12,FI13,FI15,FI16,FI17,FI5,H101,H201,H236,H301,H404,H405,I100,I101,N802,N803,N806,D211,D102,D401,E241,E305,D413,D103,D300,D412,E731
+ignore =
C401,C402,C405,E402,D105,D211,FI10,FI12,FI13,FI15,FI16,FI17,FI5,H101,H201,H236,H301,H404,H405,I100,I101,N802,N803,N806,D211,D102,D401,E241,E305,D413,D103,D412,E731
exclude = .tox,.git,./*.egg,ez_setup.py,build,externals,user-config.py,./scripts/i18n/*
min-version = 2.6
max_line_length = 100
--
To view, visit
https://gerrit.wikimedia.org/r/351007
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90dfda9d3cec457744c97e42068fded85cad2275
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>