jenkins-bot has submitted this change and it was merged.
Change subject: Fix documentation of cosmetic changes ignore list
......................................................................
Fix documentation of cosmetic changes ignore list
- Add literal value to comment where HTML entity not defined
- Wrap comments longer than 79 chars.
- Start comment with uppercase letter.
Change-Id: I56b7ab2d3219c9e9f9f90cfbdfdd3545b890e46e
---
M scripts/cosmetic_changes.py
1 file changed, 11 insertions(+), 7 deletions(-)
Approvals:
Mpaa: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/cosmetic_changes.py b/scripts/cosmetic_changes.py
index 33ae271..c774d4f 100755
--- a/scripts/cosmetic_changes.py
+++ b/scripts/cosmetic_changes.py
@@ -515,16 +515,20 @@
def resolveHtmlEntities(self, text):
ignore = [
38, # Ampersand (&)
- 39, # Bugzilla 24093
+ 39, # Single quotation mark (") - Bugzilla 24093
60, # Less than (<)
62, # Great than (>)
- 91, # Opening bracket - sometimes used intentionally inside links
- 93, # Closing bracket - sometimes used intentionally inside links
- 124, # Vertical bar (??) - used intentionally in navigation bar templates
on de:
- 160, # Non-breaking space ( ) - not supported by Firefox
textareas
+ 91, # Opening square bracket ([)
+ # - sometimes used intentionally inside links
+ 93, # Closing square bracket (])
+ # - used intentionally inside links
+ 124, # Vertical bar (|)
+ # - used intentionally in navigation bar templates on w:de
+ 160, # Non-breaking space ( )
+ # - not supported by Firefox textareas
173, # Soft-hypen (­) - enable editing
- 8206, # left-to-right mark (<r;)
- 8207, # right-to-left mark (&rtl;)
+ 8206, # Left-to-right mark (<r;)
+ 8207, # Right-to-left mark (&rtl;)
]
# ignore ' see
https://eo.wikipedia.org/w/index.php?title=Liberec&diff=next&oldid=…
#if self.site.lang == 'eo':
--
To view, visit
https://gerrit.wikimedia.org/r/145869
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56b7ab2d3219c9e9f9f90cfbdfdd3545b890e46e
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>