jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/512335 )
Change subject: [IMPR] Improvements for askForHints (4) ......................................................................
[IMPR] Improvements for askForHints (4)
- combine checkings
Change-Id: If8b9cc468c53b7215124c84eca80f19d43d2b124 --- M scripts/interwiki.py 1 file changed, 9 insertions(+), 10 deletions(-)
Approvals: Dvorapa: Looks good to me, approved jenkins-bot: Verified
diff --git a/scripts/interwiki.py b/scripts/interwiki.py index e9c6264..d4e5e76 100755 --- a/scripts/interwiki.py +++ b/scripts/interwiki.py @@ -1167,16 +1167,13 @@
def askForHints(self, counter): """Ask for hints to other sites.""" - if not self.workonme: # we don't work on it anyway - return - - if not ( - (self.untranslated or self.conf.askhints) - and not self.hintsAsked - and self.originPage - and self.originPage.exists() - and not self.originPage.isRedirectPage() - and not self.originPage.isCategoryRedirect()): + if (not self.workonme # we don't work on it anyway + or not self.untranslated and not self.conf.askhints + or self.hintsAsked + or not self.originPage + or not self.originPage.exists() + or self.originPage.isRedirectPage() + or self.originPage.isCategoryRedirect()): return
self.hintsAsked = True @@ -1189,8 +1186,10 @@
while True: newhint = pywikibot.input('Give a hint (? to see pagetext):') + if not newhint: break + if newhint == '?': t += self.conf.showtextlinkadd pywikibot.output(self.originPage.get()[:t])
pywikibot-commits@lists.wikimedia.org