jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/768197 )

Change subject: [tests] Require 'undelete' rights for TestDeletionBotWrite ......................................................................

[tests] Require 'undelete' rights for TestDeletionBotWrite

also use assertFalse/True within page_tests.TestPageDelete

Change-Id: I6747a86e62fbc51f342d9b1b8a7636e5580ec9fc --- M tests/deletionbot_tests.py M tests/page_tests.py 2 files changed, 3 insertions(+), 3 deletions(-)

Approvals: Xqt: Looks good to me, approved jenkins-bot: Verified

diff --git a/tests/deletionbot_tests.py b/tests/deletionbot_tests.py index 602507c..0e5b39f 100644 --- a/tests/deletionbot_tests.py +++ b/tests/deletionbot_tests.py @@ -22,7 +22,7 @@ family = 'wikipedia' code = 'test'

- sysop = True + rights = 'undelete' write = True

def test_delete(self): diff --git a/tests/page_tests.py b/tests/page_tests.py index 3ed030b..e3b602a 100644 --- a/tests/page_tests.py +++ b/tests/page_tests.py @@ -1038,11 +1038,11 @@ # Ensure the page exists p.text = 'pywikibot unit test page' p.save('#redirect[[unit test]]', botflag=True) - self.assertEqual(p.isRedirectPage(), True) + self.assertTrue(p.isRedirectPage()) # Test deletion p.delete(reason='pywikibot unit test', prompt=False, mark=False) self.assertEqual(p._pageid, 0) - self.assertEqual(p.isRedirectPage(), False) + self.assertFalse(p.isRedirectPage()) with self.assertRaisesRegex(NoPageError, NO_PAGE_RE): p.get(force=True)