[Pywikibot-commits] [Gerrit] pywikibot/core[master]: Remove blockreview.py from framework

jenkins-bot has submitted this change and it was merged. Change subject: Remove blockreview.py from framework ...................................................................... Remove blockreview.py from framework - This script is not finished and was never used since 6 years. Put it out of the scope of the framework and delete it. Change-Id: Ib9c583b38ad74f430af8540596ce0ad305d32b19 --- M scripts/README.rst D scripts/blockreview.py M tests/script_tests.py M tox.ini 4 files changed, 2 insertions(+), 296 deletions(-) Approvals: Dalba: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/README.rst b/scripts/README.rst index 8f9153b..4483eeb 100644 --- a/scripts/README.rst +++ b/scripts/README.rst @@ -28,8 +28,6 @@ | blockpagechecker.py | Deletes any protection templates that are on pages | | | which aren't actually protected. | +------------------------+---------------------------------------------------------+ - | blockreview.py | Bot implements blocking review process for de-wiki first| - +------------------------+---------------------------------------------------------+ | capitalize_redirects.py| Script to create a redirect of capitalize articles. | +------------------------+---------------------------------------------------------+ | casechecker.py | Script to enumerate all pages in the wikipedia and | diff --git a/scripts/blockreview.py b/scripts/blockreview.py deleted file mode 100755 index 21a351e..0000000 --- a/scripts/blockreview.py +++ /dev/null @@ -1,291 +0,0 @@ -#!/usr/bin/python -# -*- coding: utf-8 -*- -""" -This bot implements a blocking review process for de-wiki first. - -For other sites this bot script must be changed. - -This script is run by [[de:User:xqt]]. It should -not be run by other users without prior contact. -""" -# -# (C) xqt, 2010-2016 -# (C) Pywikibot team, 2014-2016 -# -# Distributed under the terms of the MIT license. -# -from __future__ import absolute_import, unicode_literals - -__version__ = '$Id$' -# - -import pywikibot - -from pywikibot import i18n -from pywikibot.bot import ExistingPageBot, SingleSiteBot -from pywikibot import pagegenerators as pg - - -class BlockreviewBot(ExistingPageBot, SingleSiteBot): - - """Block review bot.""" - - # notes - note_admin = { - 'de': u"\n\n== Sperrprüfungswunsch ==\nHallo %(admin)s,\n\n[[%(user)s]]" - u" wünscht die Prüfung seiner/ihrer Sperre vom %(time)s über die " - u"Dauer von %(duration)s. Kommentar war ''%(comment)s''. " - u"Bitte äußere Dich dazu auf der [[%(usertalk)s#%(section)s|" - u"Diskussionsseite]]. -~~~~""" - } - - note_project = { - 'de': u"\n\n== [[%(user)s]] ==\n* gesperrt am %(time)s durch " - u"{{Benutzer|%(admin)s}} für eine Dauer von %(duration)s.\n" - u"* Kommentar war ''%(comment)s''.\n* [[Benutzer:%(admin)s]]" - u" wurde [[Benutzer Diskussion:%(admin)s#Sperrprüfungswunsch|" - u"benachrichtigt]].\n* [[%(usertalk)s#%(section)s|Link zur " - u"Diskussion]]\n\n:<small>-~~~~</small>\n\n;Antrag entgegengenommen" - } - - # edit summaries - msg_admin = { - 'de': u'Bot-Benachrichtigung: Sperrprüfungswunsch von [[%(user)s]]', - } - - msg_user = { - 'de': 'Bot: Administrator [[Benutzer:%(admin)s|%(admin)s]] für ' - 'Sperrprüfung benachrichtigt', - } - - msg_done = { - 'de': u'Bot: Sperrprüfung abgeschlossen. Benutzer ist entsperrt.', - } - - unblock_tpl = { - 'de': u'Benutzer:TAXman/Sperrprüfungsverfahren', - 'pt': u'Predefinição:Discussão de bloqueio', - } - - review_cat = { - 'de': u'Wikipedia:Sperrprüfung', - } - - project_name = { - 'de': u'Benutzer:TAXman/Sperrprüfung Neu', - 'pt': u'Wikipedia:Pedidos a administradores/Discussão de bloqueio', - } - - section_header = { - 'de': 'Sperrprüfung', - } - - def __init__(self, **kwargs): - """Constructor.""" - super(BlockreviewBot, self).__init__(**kwargs) - self.info = None - self.parts = None - - @property - def generator(self): - """Generator method.""" - try: - genPage = pywikibot.Page(self.site, - self.unblock_tpl[self.site.code], - ns=10) - except KeyError: - pywikibot.error(u'Language "%s" not supported by this bot.' - % self.site.code) - raise SystemExit - return genPage.getReferences(follow_redirects=False, - withTemplateInclusion=True, - onlyTemplateInclusion=True, - namespaces=3) - - def exit(self): - """Finally print a comment.""" - if self._treat_counter == 0: - pywikibot.output('Nothing left to do.') - else: - super(BlockreviewBot, self).exit() - - def treat_page(self): - """Load the current page, do some changes, and save it.""" - talkText = self.current_page.text - if not talkText: - # sanity check. No talk page found. - return - unblock_tpl = self.unblock_tpl[self.site.code] - project_name = self.project_name[self.site.code] - user = pywikibot.User(self.site, - self.current_page.title(withNamespace=False)) - # saveAdmin = saveProject = False - talkComment = None - for templates in self.current_page.templatesWithParams(): - if templates[0].title() == unblock_tpl: - if not self.getInfo(user): - pywikibot.output('No block entry found. Skipping') - # TODO: Notify user or delete template - continue - # Step 1 - # a new template is set on blocked users talk page. - # Notify the blocking admin - if templates[1] == [] or templates[1][0] == u'1': - if self.info['action'] == 'block' or user.isBlocked(): - if self.site.sitename == 'wikipedia:de': - admin = pywikibot.User(self.site, - user.getprops()['blockedby']) - assert admin == self.info.user(), ( - "Blocking admin doesn't match user property") - adminPage = admin.getUserTalkPage() - adminText = adminPage.text - note = i18n.translate(self.site.code, - self.note_admin, - self.parts) - comment = i18n.translate(self.site.code, - self.msg_admin, - self.parts) - adminText += note - self.userPut(adminPage, adminPage.text, adminText, - summary=comment, minorEdit=False, - ignore_save_related_errors=True) - # test for pt-wiki - # just print all sysops talk pages - elif self.site.sitename == 'wikipedia:pt': - gen = pg.PreloadingGenerator(self.SysopGenerator()) - for sysop in gen: - pywikibot.output(sysop.title()) - - talkText = talkText.replace(u'{{%s}}' % unblock_tpl, - u'{{%s|2}}' % unblock_tpl) - talkText = talkText.replace(u'{{%s|1}}' % unblock_tpl, - u'{{%s|2}}' % unblock_tpl) - talkComment = i18n.translate(self.site.code, - self.msg_user - % self.parts) - - # some test stuff - if self.site.user() == u'Xqbot': - testPage = pywikibot.Page(self.site, - 'Benutzer:Xqt/Test') - test = testPage.get() - test += note - self.userPut(testPage, testPage.text, test, - summary='[[WP:BA#SPP-Bot|SPPB-Test]]', - ignore_save_related_errors=True) - else: - # nicht blockiert. Fall auf DS abschließen - talkText = talkText.replace(u'{{%s}}' % unblock_tpl, - u'{{%s|4}}' % unblock_tpl) - talkText = talkText.replace(u'{{%s|1}}' % unblock_tpl, - u'{{%s|4}}' % unblock_tpl) - talkComment = i18n.translate(self.site.code, - self.msg_done) - # Step 2 - # Admin has been notified. - # Wait for 2 hours, than put a message to the project page - elif templates[1][0] == u'2': - if self.info['action'] == 'block' or user.isBlocked(): - # TODO: check whether wait time is gone - # check whether this entry already esists - project = pywikibot.Page(self.site, project_name) - projText = project.get() - note = i18n.translate(self.site.code, - self.note_project, - self.parts) - comment = i18n.translate(self.site.code, - self.msg_admin, - self.parts) - projText += note - self.userPut(project, project.text, projText, - summary=comment, botflag=False, - ignore_save_related_errors=True) - talkText = talkText.replace(u'{{%s|2}}' % unblock_tpl, - u'{{%s|3}}' % unblock_tpl) - talkComment = u'Bot: [[%s|Wikipedia:Sperrprüfung]] eingetragen' \ - % project_name - else: - # User is unblocked. Review can be closed - talkText = talkText.replace(u'{{%s|2}}' % unblock_tpl, - u'{{%s|4}}' % unblock_tpl) - talkComment = i18n.translate(self.site.code, - self.msg_done) - # Step 3 - # Admin is notified, central project page has a message - # Discussion is going on - # Check whether it can be closed - elif templates[1][0] == u'3': - if self.info['action'] == 'block' or user.isBlocked(): - pass - else: - # User is unblocked. Review can be closed - talkText = talkText.replace(u'{{%s|3}}' % unblock_tpl, - u'{{%s|4}}' % unblock_tpl) - talkComment = i18n.translate(self.site.code, - self.msg_done) - # Step 4 - # Review is closed - elif templates[1][0] == u'4': - # nothing left to do - pass - else: - # wrong template found - pass - - # at last if there is a talk comment, users talk page must be changed - if talkComment: - self.put_current(talkText, summary=talkComment) - - def getInfo(self, user): - """Get block info for a given user.""" - if not self.info: - assert isinstance(user, pywikibot.Page), ( - 'user actual parameter is not a Page object') - for logentry in self.site.logevents('block', page=user): - if logentry.action() in ('block', 'reblock'): - break - else: - return - self.info = logentry - assert logentry.page() == user, ( - "logentry.page() doesn't match given user") - self.parts = { - 'admin': logentry.user(), - 'user': logentry.page().title(), - 'usertalk': user.getUserTalkPage().title(), - 'section': i18n.translate(self.site.code, - self.section_header), - 'time': str(logentry.timestamp()), - 'duration': logentry._params['duration'], - 'comment': logentry.comment(), - } - - def SysopGenerator(self): - """Iter all sysops of a site.""" - for user in self.site.allusers(group='sysop'): - # exclude sysop bots - if 'bot' not in user['groups']: - # yield the sysop talkpage - yield pywikibot.User(self.site, user['name']) - - -def main(*args): - """ - Process command line arguments and invoke bot. - - If args is an empty list, sys.argv is used. - - @param args: command line arguments - @type args: list of unicode - """ - unknown_args = pywikibot.handle_args(args) - if unknown_args: - pywikibot.bot.suggest_help(unknown_parameters=unknown_args) - return False - else: - bot = BlockreviewBot() - bot.run() - return True - -if __name__ == "__main__": - main() diff --git a/tests/script_tests.py b/tests/script_tests.py index 2005706..d3d3fd4 100644 --- a/tests/script_tests.py +++ b/tests/script_tests.py @@ -1,7 +1,7 @@ # -*- coding: utf-8 -*- """Test that each script can be compiled and executed.""" # -# (C) Pywikibot team, 2014 +# (C) Pywikibot team, 2014-2016 # # Distributed under the terms of the MIT license. # @@ -114,7 +114,6 @@ auto_run_script_list = [ 'blockpageschecker', - 'blockreview', 'casechecker', 'catall', 'category_redirect', diff --git a/tox.ini b/tox.ini index 166e113..b818c4c 100644 --- a/tox.ini +++ b/tox.ini @@ -153,7 +153,7 @@ pywikibot/userinterfaces/win32_unicode.py : +N801, N812 tests/page_tests.py : +E241 scripts/,/pagegenerators.parameterHelp/ : +E241 - scripts/blockreview.py,scripts/imagetransfer.py,scripts/interwiki.py,scripts/maintenance/wikimedia_sites.py : +E241 + scripts/imagetransfer.py,scripts/interwiki.py,scripts/maintenance/wikimedia_sites.py : +E241 tests/ui_tests.py : +D102, D103, N801 tests/__init__.py,tests/aspects.py,tests/script_tests.py,tests/site_detect_tests.py : +T001, T003 tests/pwb/ : +T001, T003 -- To view, visit https://gerrit.wikimedia.org/r/307327 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9c583b38ad74f430af8540596ce0ad305d32b19 Gerrit-PatchSet: 3 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: Dalba &lt;dalba.wiki(a)gmail.com&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Ladsgroup &lt;Ladsgroup(a)gmail.com&gt; Gerrit-Reviewer: jenkins-bot <>