[Pywikibot-commits] [Gerrit] Add noqa support to pep8 E731 - change (pywikibot/core)

jenkins-bot has submitted this change and it was merged. Change subject: Add noqa support to pep8 E731 ...................................................................... Add noqa support to pep8 E731 pep8 1.6.0+ includes E731 for assigned lambda's, but it does not support 'noqa' for this code. flake8-putty allows specific codes to be whitelisted in specific files and when a regex condition has been met. Change-Id: If8a22d57f4b2b22695314810825b80c7b581a07b --- M pwb.py M tox.ini 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: John Vandenberg: Looks good to me, but someone else must approve Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/pwb.py b/pwb.py index fdd6fd4..834620b 100755 --- a/pwb.py +++ b/pwb.py @@ -77,7 +77,7 @@ except RuntimeError: remove_modules() - pwb = lambda: None + pwb = lambda: None # noqa: E731 pwb.argvu = [] diff --git a/tox.ini b/tox.ini index bd09641..1de1ab7 100644 --- a/tox.ini +++ b/tox.ini @@ -102,6 +102,7 @@ accept-encodings = utf-8 require-code = true putty-ignore = + pwb.py,scripts/interwiki.py,scripts/flickrripper.py,pywikibot/site.py, /# noqa: E731/ : +E731 generate_family_file.py : +D102,T001 pwb.py : +T001 pywikibot/cosmetic_changes.py : +D102, D103 -- To view, visit https://gerrit.wikimedia.org/r/263662 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8a22d57f4b2b22695314810825b80c7b581a07b Gerrit-PatchSet: 4 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: AndyTechGuy &lt;andytechdude(a)gmail.com&gt; Gerrit-Reviewer: Hashar &lt;hashar(a)free.fr&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Legoktm &lt;legoktm.wikipedia(a)gmail.com&gt; Gerrit-Reviewer: Samtar &lt;samtarling6(a)gmail.com&gt; Gerrit-Reviewer: XZise &lt;CommodoreFabianus(a)gmx.de&gt; Gerrit-Reviewer: jenkins-bot <>