[Pywikibot-commits] [Gerrit] [IMPROV] nowcommons: Query at most one users - change (pywikibot/core)

jenkins-bot has submitted this change and it was merged. Change subject: [IMPROV] nowcommons: Query at most one users ...................................................................... [IMPROV] nowcommons: Query at most one users To verify if a page is used it's only necessary to query one using page instead of all. Change-Id: I9bbb206ede1723c33410c3b50e05dae71ecc265f --- M scripts/nowcommons.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/scripts/nowcommons.py b/scripts/nowcommons.py index cfd9d0b..433dd9c 100755 --- a/scripts/nowcommons.py +++ b/scripts/nowcommons.py @@ -374,9 +374,9 @@ bot.run() # If the image is used with the urlname the # previous function won't work - if len(list(pywikibot.FilePage(self.site, - page.title()).usingPages())) > 0 and \ - self.getOption('replaceloose'): + is_used = bool(list(pywikibot.FilePage( + self.site, page.title()).usingPages(total=1))) + if is_used and self.getOption('replaceloose'): bot = ImageBot( pg.FileLinksGenerator( localImagePage), -- To view, visit https://gerrit.wikimedia.org/r/240359 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bbb206ede1723c33410c3b50e05dae71ecc265f Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: XZise &lt;CommodoreFabianus(a)gmx.de&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Ladsgroup &lt;ladsgroup(a)gmail.com&gt; Gerrit-Reviewer: jenkins-bot <>