[Pywikibot-commits] [Gerrit] pywikibot/core[master]: proofreadpage.py: raise TypeError, not ValueError

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/355904 ) Change subject: proofreadpage.py: raise TypeError, not ValueError ...................................................................... proofreadpage.py: raise TypeError, not ValueError Raise correct Exception when assigning wrong object to ProofreadPage.index property. Tests added. Change-Id: I1217f272e77db414feb389253e8bfe17a54a94dc --- M pywikibot/proofreadpage.py M tests/proofreadpage_tests.py 2 files changed, 6 insertions(+), 4 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/pywikibot/proofreadpage.py b/pywikibot/proofreadpage.py index 47bf1ab..60546c4 100644 --- a/pywikibot/proofreadpage.py +++ b/pywikibot/proofreadpage.py @@ -173,8 +173,8 @@ @index.setter def index(self, value): if not isinstance(value, IndexPage): - raise ValueError('value %s must be a IndexPage object.' - % value) + raise TypeError('value %s must be a IndexPage object.' + % value) self._index = (value, None) @index.deleter diff --git a/tests/proofreadpage_tests.py b/tests/proofreadpage_tests.py index 21e9762..49b6e75 100644 --- a/tests/proofreadpage_tests.py +++ b/tests/proofreadpage_tests.py @@ -268,13 +268,15 @@ page = ProofreadPage(self.site, self.valid['title']) index_page = IndexPage(self.site, self.valid['index']) - # Test propery. + # Test property. self.assertEqual(page.index, index_page) # Test deleter del page.index self.assertFalse(hasattr(page, '_index')) - # Test setter + # Test setter with wrong type. + self.assertRaises(TypeError, setattr, page, 'index', 'invalid index') + # Test setter with correct type. page.index = index_page self.assertEqual(page.index, index_page) -- To view, visit https://gerrit.wikimedia.org/r/355904 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1217f272e77db414feb389253e8bfe17a54a94dc Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Mpaa &lt;mpaa.wiki(a)gmail.com&gt; Gerrit-Reviewer: Magul &lt;tomasz.magulski(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: jenkins-bot <>