[Pywikibot-commits] [Gerrit] [FIX] Fix errors in proofreadpage.py and djvutxt.py - change (pywikibot/core)

jenkins-bot has submitted this change and it was merged. Change subject: [FIX] Fix errors in proofreadpage.py and djvutxt.py ...................................................................... [FIX] Fix errors in proofreadpage.py and djvutxt.py Fix following errors in djvu.txt.py: - default pages: start=1, end=number of pages in djvu file. - user name is taken care by ProofreadPage() when preloading. Fix the follwing in Proofreadpage(): - avoid resetting the page content if self._decompose_page() is called by self.text property (e.g. when adding user name to the text). Change-Id: Ied326eece98e42e724b2d8a205366f6cbb17ccab --- M pywikibot/proofreadpage.py M scripts/djvutext.py 2 files changed, 3 insertions(+), 6 deletions(-) Approvals: XZise: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/proofreadpage.py b/pywikibot/proofreadpage.py index 0703b89..a14e2f2 100644 --- a/pywikibot/proofreadpage.py +++ b/pywikibot/proofreadpage.py @@ -261,7 +261,8 @@ exception Error: the page is not formatted according to ProofreadPage extension. """ - if not self.text: # Property force page text loading. + # Property force page text loading. + if not (hasattr(self, '_text') or self.text): self._create_empty_page() return diff --git a/scripts/djvutext.py b/scripts/djvutext.py index 725c489..5f0ee09 100644 --- a/scripts/djvutext.py +++ b/scripts/djvutext.py @@ -110,10 +110,6 @@ # Overwrite body of the page with content from djvu page.body = self._djvu.get_page(page.page_number) - - # Add username in header if page does not exists. - if not page.exists(): - page.user = page.site.user() new_text = page.text summary = self.getOption('summary') @@ -135,7 +131,7 @@ """ index = None djvu_path = '.' # default djvu file directory - pages = '1' + pages = '1-' options = {} # Parse command line arguments. -- To view, visit https://gerrit.wikimedia.org/r/240434 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied326eece98e42e724b2d8a205366f6cbb17ccab Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Mpaa &lt;mpaa.wiki(a)gmail.com&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Ladsgroup &lt;ladsgroup(a)gmail.com&gt; Gerrit-Reviewer: XZise &lt;CommodoreFabianus(a)gmx.de&gt; Gerrit-Reviewer: jenkins-bot <>