[Pywikibot-commits] [Gerrit] Revert "Remove unnecessary return in Siteinfo._get_general" - change (pywikibot/core)

jenkins-bot has submitted this change and it was merged. Change subject: Revert "Remove unnecessary return in Siteinfo._get_general" ...................................................................... Revert "Remove unnecessary return in Siteinfo._get_general" This reverts commit c6e92cacbcdd56ab10810be9c36d3d18deebe7ef. Change-Id: I1b15978dc279e3e3ce8b49101a9aa757378c3f79 --- M pywikibot/site.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: John Vandenberg: Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/site.py b/pywikibot/site.py index bc9ce9f..13da02c 100644 --- a/pywikibot/site.py +++ b/pywikibot/site.py @@ -1046,6 +1046,8 @@ default_info = self._get_siteinfo(props, expiry) for prop in props: self._cache[prop] = default_info[prop] + if key in default_info: + return default_info[key] if key in self._cache['general'][0]: return self._cache['general'][0][key], self._cache['general'] else: -- To view, visit https://gerrit.wikimedia.org/r/158014 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b15978dc279e3e3ce8b49101a9aa757378c3f79 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Mpaa &lt;mpaa.wiki(a)gmail.com&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Ladsgroup &lt;ladsgroup(a)gmail.com&gt; Gerrit-Reviewer: Merlijn van Deen &lt;valhallasw(a)arctus.nl&gt; Gerrit-Reviewer: jenkins-bot <>