jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/407717 )
Change subject: [bugfix][TEST] Fix broken solve_disambiguation.py test ......................................................................
[bugfix][TEST] Fix broken solve_disambiguation.py test
Travis still failing, because the new function is (as written in its description) supposed to return list of str, not list of Link
Bug: T186316 Change-Id: I290b697780365576b03f48c4dcaa585b14455029 --- M tests/solve_disambiguation_tests.py 1 file changed, 2 insertions(+), 4 deletions(-)
Approvals: Zoranzoki21: Looks good to me, but someone else must approve Xqt: Looks good to me, approved jenkins-bot: Verified
diff --git a/tests/solve_disambiguation_tests.py b/tests/solve_disambiguation_tests.py index ab9e766..0ef9a45 100644 --- a/tests/solve_disambiguation_tests.py +++ b/tests/solve_disambiguation_tests.py @@ -27,9 +27,7 @@ minimum=0) page.text = '* [[Link1]]\n* [[Link2]]' newlinks = bot.get_disambiguation_links(page) - links = [ - pywikibot.Link('Link1', self.site), - pywikibot.Link('Link2', self.site)] + links = ['Link1', 'Link2'] self.assertEqual(newlinks, links)
def test_get_without_templates(self): @@ -39,7 +37,7 @@ minimum=0) page.text = '* [[Link1]]\n{{Disambig}}' newlinks = bot.get_disambiguation_links(page) - links = [pywikibot.Link('Link1', self.site)] + links = ['Link1'] self.assertEqual(newlinks, links)