jenkins-bot merged this change.

View Change

Approvals: Zoranzoki21: Looks good to me, but someone else must approve Xqt: Looks good to me, approved jenkins-bot: Verified
[bugfix][TEST] Fix broken solve_disambiguation.py test

Travis still failing, because the new function is (as written in its
description) supposed to return list of str, not list of Link

Bug: T186316
Change-Id: I290b697780365576b03f48c4dcaa585b14455029
---
M tests/solve_disambiguation_tests.py
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tests/solve_disambiguation_tests.py b/tests/solve_disambiguation_tests.py
index ab9e766..0ef9a45 100644
--- a/tests/solve_disambiguation_tests.py
+++ b/tests/solve_disambiguation_tests.py
@@ -27,9 +27,7 @@
minimum=0)
page.text = '* [[Link1]]\n* [[Link2]]'
newlinks = bot.get_disambiguation_links(page)
- links = [
- pywikibot.Link('Link1', self.site),
- pywikibot.Link('Link2', self.site)]
+ links = ['Link1', 'Link2']
self.assertEqual(newlinks, links)

def test_get_without_templates(self):
@@ -39,7 +37,7 @@
minimum=0)
page.text = '* [[Link1]]\n{{Disambig}}'
newlinks = bot.get_disambiguation_links(page)
- links = [pywikibot.Link('Link1', self.site)]
+ links = ['Link1']
self.assertEqual(newlinks, links)


To view, visit change 407717. To unsubscribe, visit settings.

Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I290b697780365576b03f48c4dcaa585b14455029
Gerrit-Change-Number: 407717
Gerrit-PatchSet: 1
Gerrit-Owner: Dvorapa <dvorapa@seznam.cz>
Gerrit-Reviewer: Dalba <dalba.wiki@gmail.com>
Gerrit-Reviewer: Dvorapa <dvorapa@seznam.cz>
Gerrit-Reviewer: John Vandenberg <jayvdb@gmail.com>
Gerrit-Reviewer: Xqt <info@gno.de>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444@gmail.com>
Gerrit-Reviewer: jenkins-bot <>