jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/453576 )
Change subject: [IMPR] improve hash method for BasePage and Link
......................................................................
[IMPR] improve hash method for BasePage and Link
- use _cmpkey to build hash BasePage
- simplify Link's hash method by using sitename and canonical_title as tuple
Change-Id: I346b050665b3337cca0ff9e22e8d493547b2a7af
---
M pywikibot/page.py
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Framawiki: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/page.py b/pywikibot/page.py
index e2f2fcc..46021a9 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -413,7 +413,7 @@
This relies on the fact that the string
representation of an instance can not change after the construction.
"""
- return hash(unicode(self))
+ return hash(self._cmpkey())
def full_url(self):
"""Return the full URL."""
@@ -5846,9 +5846,7 @@
def __hash__(self):
"""A stable identifier to be used as a key in
hash-tables."""
- return hash(u'%s:%s:%s' % (self.site.family.name,
- self.site.code,
- self.title))
+ return hash((self.site.sitename, self.canonical_title()))
@classmethod
def fromPage(cls, page, source=None):
--
To view, visit
https://gerrit.wikimedia.org/r/453576
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I346b050665b3337cca0ff9e22e8d493547b2a7af
Gerrit-Change-Number: 453576
Gerrit-PatchSet: 4
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: Zhuyifei1999 <zhuyifei1999(a)gmail.com>
Gerrit-Reviewer: Zoranzoki21 <zorandori4444(a)gmail.com>
Gerrit-Reviewer: jenkins-bot (75)
Gerrit-CC: Matěj Suchánek <matejsuchanek97(a)gmail.com>